8000 docs(eslint-plugin): add instructions for using Airbnb's config by aboyton · Pull Request #177 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content

docs(eslint-plugin): add instructions for using Airbnb's config #177

New issue

Have a question about this project? Sign up for a free G 8000 itHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2019

Conversation

aboyton
Copy link
Contributor
@aboyton aboyton commented Feb 1, 2019

Here's how I've got AIrbnb's style guides working.

Ref #147

bradzacher
bradzacher previously approved these changes Feb 1, 2019
Copy link
Member
@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change otherwise LGTM.

Co-Authored-By: aboyton <aboyton@users.noreply.github.com>
@aboyton aboyton dismissed stale reviews from bradzacher via c7c5955 February 1, 2019 04:59
j-f1
j-f1 previously approved these changes Feb 2, 2019

Airbnb has two configs, a base one [`eslint-config-airbnb-base`](https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb-base) and one that includes rules for React [`eslint-config-airbnb`](https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb).

First you'll need to install the config acrording to the instructions in one of the links above. `npx install-peerdeps --dev eslint-config-airbnb` or `npx install-peerdeps --dev eslint-config-airbnb-base` should work if you are using **npm 5+**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acrording

Typo: should be "according"

Copy link
Member
@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo already pointed out

@armano2 armano2 changed the title Add instructions for using Airbnb's config docs(eslint-plugin): add instructions for using Airbnb's config Feb 3, 2019
@JamesHenry JamesHenry merged commit 2e5b46e into typescript-eslint:master Feb 4, 2019
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0