refactor(ts-estree): simplify calculation of method location #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=========================================
+ Coverage 95.1% 95.2% +0.09%
=========================================
Files 49 49
Lines 2493 2480 -13
Branches 373 371 -2
=========================================
- Hits 2371 2361 -10
+ Misses 73 71 -2
+ Partials 49 48 -1
|
JamesHenry
approved these changes
Jan 27, 2019
uniqueiniquity
pushed a commit
to uniqueiniquity/typescript-eslint
that referenced
this pull request
Jan 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
range and location of
FunctionExpressioninMethodDeclaration,SetAccessor,GetAccessorwas calculated in different way, this change unifies this calculation and removes no longer used helper functionfindFirstMatchingToken.we have already test cases for this code, and this change doesn't changes to AST.