8000 chore: update `eslint-plugin-perfectionist` to `v4` by hugop95 · Pull Request #11185 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore: update eslint-plugin-perfectionist to v4 #11185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 16, 2025
Merged

chore: update eslint-plugin-perfectionist to v4 #11185

merged 9 commits into from
May 16, 2025

Conversation

hugop95
Copy link
Contributor
@hugop95 hugop95 commented May 7, 2025 •
edited by kirkwaiblinger
Loading

PR Checklist

Overview

Updating perfectionist from V3 to V4 requires a couple of changes in the Eslint configuration.

This PR updates the config in order to have the minimal amount of changes in the codebase.

hugop95 added 3 commits May 7, 2025 12:41
@hugop95
chore: update dependencies
a83902c
@hugop95
chore: update eslint config
61dbefe 
- `perfectionist` v4 uses RegExp to match, and `type` will match `typeSomething`, unlike in v3 which used `minimatch` by default.
@hugop95
chore: sort-classes fixes
a84726f 
- The default `groups` option was updated in v4 (azat-io/eslint-plugin-perfectionist#320). Forcing back to v3 default option.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @hugop95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented May 7, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 15260e5
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68274357a5c95f000874a90d
😎 Deploy Preview https://deploy-preview-11185--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 84 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud 8000 Nx Cloud
Copy link
nx-cloud bot commented May 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 15260e5.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 6m 27s View ↗
nx test typescript-estree ✅ Succeeded 45s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 27s View ↗
nx test type-utils ✅ Succeeded 23s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test scope-manager ✅ Succeeded 19s View ↗
nx typecheck ast-spec ✅ Succeeded 2s View ↗
nx test utils ✅ Succeeded 12s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 14:13:04 UTC

@hugop95 hugop95 force-pushed the feat/perfectionist-v4 branch from 48d140b to 1a1ba0d Compare May 7, 2025 11:13
@hugop95 hugop95 changed the title chore: update perfectionist to v4 chore: update eslint-plugin-perfectionist to v4 May 7, 2025
@hugop95 hugop95 mentioned this pull request May 7, 2025
Closed
@codecov Codecov
Copy link
codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (d2dfe73) to head (15260e5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11185   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         499      499           
  Lines       50845    50845           
  Branches     8384     8384           
=======================================
  Hits        46231    46231           
  Misses       4599     4599           
  Partials       15       15
Flag Coverage Δ
unittest 90.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/eslint-plugin/src/rules/no-restricted-types.ts 93.98% <100.00%> (ø)
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 98.26% <ø> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts 96.19% <ø> (ø)
...ackages/scope-manager/src/referencer/Referencer.ts 97.94% <ø> (ø)
packages/type-utils/src/isUnsafeAssignment.ts 90.54% <100.00%> (ø)
packages/utils/src/ts-eslint/SourceCode.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hugop95 hugop95 mentioned this pull request May 7, 2025
Closed
3 tasks
kirkwaiblinger
kirkwaiblinger previously approved these changes May 14, 2025
View reviewed changes
@kirkwaiblinger
Copy link
Member

Thanks for sending this in! Looks good to me! I've gone ahead and reviewed/approved this since I'm guessing it was only drafted due to waiting on the "accepting PRs" label, but we'll wait for you to undraft it in case there's anything else that needs to be done before merging. Also, would you mind merging in from main and resolving the merge conflicts when you undraft? Thanks!

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 14, 2025
@hugop95 hugop95 marked this pull request as ready for review May 14, 2025 21:03
@hugop95 hugop95 requested a review from kirkwaiblinger May 14, 2025 21:04
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 14, 2025
kirkwaiblinger
kirkwaiblinger previously approved these changes May 14, 2025
View reviewed changes
Copy link
Member
@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

8000

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 14, 2025
@kirkwaiblinger kirkwaiblinger merged commit 220c38c into typescript-eslint:main May 16, 2025
59 checks passed
@hugop95 hugop95 deleted the feat/perfectionist-v4 branch May 16, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: update eslint-plugin-perfectionist to v4
3 participants
@hugop95 @kirkwaiblinger @JoshuaKGoldberg
0