8000 chore: fix integration-tests by aryaemami59 · Pull Request #10906 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore: fix integration-tests #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2025
Merged

chore: fix integration-tests #10906

merged 1 commit into from
Mar 2, 2025

Conversation

aryaemami59
Copy link
Contributor
@aryaemami59 aryaemami59 commented Mar 2, 2025 •
edited by kirkwaiblinger
Loading

PR Checklist

Overview

Fixes failing integration-tests.

Edit by @kirkwaiblinger:

Context - same issue as #10870, since DefinitelyTyped/DefinitelyTyped#72026 landed.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Mar 2, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 27e6099
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67c3fdac3517430008c45490
😎 Deploy Preview https://deploy-preview-10906--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (🟢 up 8 from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Mar 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3355172.

Command Status Duration Result
nx test eslint-plugin ❌ Failed 6m 24s View ↗
nx test eslint-plugin --coverage=false ❌ Failed 6m 21s View ↗
nx test visitor-keys ✅ Succeeded <1s View ↗
nx test type-utils ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test utils ✅ Succeeded <1s View ↗
nx test typescript-estree ✅ Succeeded <1s View ↗
nx test scope-manager ✅ Succeeded <1s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-02 06:24:20 UTC

@aryaemami59 aryaemami59 force-pushed the chore/fix-integration-tests branch from 3355172 to 27e6099 Compare March 2, 2025 06:41
@codecov Codecov
Copy link
codecov bot commented Mar 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (4dd447c) to head (27e6099).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10906   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         468      468           
  Lines       16027    16040   +13     
  Branches     4640     4649    +9     
=======================================
+ Hits        14013    14025   +12     
  Misses       1658     1658           
- Partials      356      357    +1
Flag Coverage Δ
unittest 87.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 2, 2025
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3c7b8ff into typescript-eslint:main Mar 2, 2025
58 checks passed
@aryaemami59 aryaemami59 deleted the chore/fix-integration-tests branch March 2, 2025 07:05
@kirkwaiblinger kirkwaiblinger mentioned this pull request Mar 2, 2025
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @JoshuaKGoldberg
0