chore: update some package scripts and dependency config #10765
Conversation
|
Thanks for the PR, @aryaemami59! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 81147b6.
☁️ Nx Cloud last updated this comment at |
5663aba to
79768d4
Compare
9d8fec3 to
2f16d41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10765 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 499 499
Lines 50845 50845
Branches 8384 8384
=======================================
Hits 46231 46231
Misses 4599 4599
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2f16d41 to
abd45dc
Compare
e2dc2a7 to
a00d190
Compare
719098a to
2d95a14
Compare
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…aemami59/typescript-eslint; branch 'main' of https://github.com/typescript-eslint/typescript-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
| @@ -135,9 +136,10 @@ | |||
| ], | |||
| "production": [ | |||
| "default", | |||
| "!{projectRoot}/**/?(*.)+(test).[jt]s?(x)?(.snap)", | |||
| "!{projectRoot}/**/?(*.)+(test).?(m|c)[jt]s?(x)?(.snap|.shot)", | |||
There was a problem hiding this comment.
this is done because of the newly added docs.test.mts file.
|
There's some good stuff in here but some nx config changes which don't really make sense. I was thinking I would push to the branch but I don't want to end up wiping your contributor data, so I'm going to merge this and then immediately work on revamping the nx setup |
nx usage with lifecycle scripts across all projects|
I will post a loom covering why these nx changes were not optimal |
|
@JamesHenry You can let me know what changes you don't like and I can get rid of them. |
|
The PR to update things and an explainer loom are here, thanks! #11226 |
PR Checklist
jesttovitest#10679 (comment)Overview
EDIT BY @kirkwaiblinger:
This PR enforces dependencies such that
git clean -xfd && SKIP_POSTINSTALL_BUILD=true yarn && yarn testwill succeed. Previously it did not succeed since some of the test tasks apparently had undeclared dependencies on build tasks.