8000 chore(eslint-plugin): use `getConstraintInfo` in no-unnecessary-template-expression by 43081j · Pull Request #10578 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

chore(eslint-plugin): use getConstraintInfo in no-unnecessary-template-expression #10578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

chore(eslint-plugin): use getConstraintInfo in no-unnecessary-template-expression #10578

merged 1 commit into from
Jan 3, 2025

Conversation

43081j
Copy link
Contributor
@43081j 43081j commented Dec 31, 2024

Switches the no-unnecessary-template-expression rule to use getConstraintInfo internally.

Related #10569

Assuming I've done the right thing here, let me know and i'll happily do most of the others. I'm just using this as a way to get my head back into the codebase

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Dec 31, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 21be05c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6775245eeb8afb0009081de4
😎 Deploy Preview https://deploy-preview-10578--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Dec 31, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 21be05c.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-01 20:50:15 UTC

@codecov Codecov
Copy link
codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable line 8000 s are covered by tests ✅

Project coverage is 86.90%. Comparing base (4dbf48b) to head (21be05c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10578   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         446      446           
  Lines       15502    15505    +3     
  Branches     4516     4517    +1     
=======================================
+ Hits        13472    13475    +3     
  Misses       1675     1675           
  Partials      355      355
Flag Coverage Δ
unittest 86.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/src/rules/no-unnecessary-template-expression.ts 98.88% <100.00%> (+0.03%) ⬆️

@kirkwaiblinger kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Dec 31, 2024
@43081j
chore(eslint-plugin): use getConstraintInfo in no-unnecessary-templ…
21be05c 
…ate-expression

Switches the `no-unnecessary-template-expression` rule to use
`getConstraintInfo` internally.

Related typescript-eslint#10569
@43081j 43081j requested a review from kirkwaiblinger January 1, 2025 11:18
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 1, 2025
kirkwaiblinger
kirkwaiblinger approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member
@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for sending this in!!

FYI it's not a big deal but, but for future reference we like to avoid force-pushing, see https://typescript-eslint.io/contributing/pull-requests/

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 1, 2025
@43081j
Copy link
Contributor Author
43081j commented Jan 1, 2025

Yep it helps keep a trail for reviews etc

I just happen to be working in a branch I cut a few more out of, so I've been rebasing a fair amount locally

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell!

@JoshuaKGoldberg JoshuaKGoldberg merged commit c7154bf into typescript-eslint:main Jan 3, 2025
65 checks passed
@43081j 43081j deleted the gti-tpl-expr branch January 3, 2025 22:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@43081j @JoshuaKGoldberg @kirkwaiblinger
0