8000 fix(eslint-plugin): [no-unnecessary-condition] handle noUncheckedIndexedAccess true by yeonjuan · Pull Request #10514 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(eslint-plugin): [no-unnecessary-condition] handle noUncheckedIndexedAccess true #10514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(eslint-plugin): [no-unnecessary-condition] handle noUncheckedIndexedAccess true #10514

merged 3 commits into from
Dec 23, 2024

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 31f10b0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6761b7da07027900081c63fb
😎 Deploy Preview https://deploy-preview-10514--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 21 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Dec 17, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 31f10b0.

Command Status Du 10000 ration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 24s View ↗
nx run-many --target=clean ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-21 15:00:51 UTC

@codecov Codecov
Copy link
codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (b2ce158) to head (31f10b0).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10514   +/-   ##
=======================================
  Coverage   86.78%   86.79%           
=======================================
  Files         445      445           
  Lines       15366    15369    +3     
  Branches     4475     4475           
=======================================
+ Hits        13336    13339    +3     
  Misses       1675     1675           
  Partials      355      355
Flag Coverage Δ
unittest 86.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.21% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@yeonjuan yeonjuan marked this pull request as ready for review December 17, 2024 17:19
@yeonjuan yeonjuan changed the title fix(eslint-plugin): [no-unnecessary-condition] handle index signature fix(eslint-plugin): [no-unnecessary-condition] handle when noUncheckedIndexedAccess true Dec 17, 2024
@yeonjuan yeonjuan changed the title fix(eslint-plugin): [no-unnecessary-condition] handle when noUncheckedIndexedAccess true fix(eslint-plugin): [no-unnecessary-condition] handle noUncheckedIndexedAccess true Dec 17, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky! Thanks for the fix and good discussion behind it. I'm irked I didn't catch it in review originally. 😄

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 21, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 83c3bbf into typescript-eslint:main Dec 23, 2024
62 of 64 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 23, 2024
@renovate
Update typescript-eslint monorepo to v8.18.2
1e3f82f 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.18.1 | 8.18.2 |
| npm        | @typescript-eslint/parser        | 8.18.1 | 8.18.2 |


## [v8.18.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8182-2024-12-23)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unnecessary-condition] handle noUncheckedIndexedAccess true ([#10514](typescript-eslint/typescript-eslint#10514))
-   **eslint-plugin:** \[consistent-type-assertions] allow default assertionStyle option ([#10512](typescript-eslint/typescript-eslint#10512))
-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type/value context ([#10503](typescript-eslint/typescript-eslint#10503))
-   **eslint-plugin:** \[no-unsafe-type-assertion] fix for unsafe assertion to a constrained type parameter ([#10461](typescript-eslint/typescript-eslint#10461))
-   **eslint-plugin:** \[consistent-indexed-object-style] use a suggestion over an auto-fix if can't reliably determine that produced index signature is valid ([#10490](typescript-eslint/typescript-eslint#10490))
-   **eslint-plugin:** \[no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter ([#10473](typescript-eslint/typescript-eslint#10473))
-   **eslint-plugin:** \[prefer-reduce-type-parameter] don't report cases in which the fix results in a type error ([#10494](typescript-eslint/typescript-eslint#10494))
-   **eslint-plugin:** \[no-deprecated] not reporting usages of deprecat
8000
ed declared constants as object value ([#10498](typescript-eslint/typescript-eslint#10498))

##### ❤️ Thank You

-   Luke Deen Taylor [@controversial](https://github.com/controversial)
-   Ronen Amiel
-   Scott O'Hara
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)
-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Dec 23, 2024
@renovate
fix(deps): update typescript-eslint monorepo to v8.18.2
5f8d091 
##### [v8.18.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8182-2024-12-23)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unnecessary-condition] handle noUncheckedIndexedAccess true ([#10514](typescript-eslint/typescript-eslint#10514))
-   **eslint-plugin:** \[consistent-type-assertions] allow default assertionStyle option ([#10512](typescript-eslint/typescript-eslint#10512))
-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type/value context ([#10503](typescript-eslint/typescript-eslint#10503))
-   **eslint-plugin:** \[no-unsafe-type-assertion] fix for unsafe assertion to a constrained type parameter ([#10461](typescript-eslint/typescript-eslint#10461))
-   **eslint-plugin:** \[consistent-indexed-object-style] use a suggestion over an auto-fix if can't reliably determine that produced index signature is valid ([#10490](typescript-eslint/typescript-eslint#10490))
-   **eslint-plugin:** \[no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter ([#10473](typescript-eslint/typescript-eslint#10473))
-   **eslint-plugin:** \[prefer-reduce-type-parameter] don't report cases in which the fix results in a type error ([#10494](typescript-eslint/typescript-eslint#10494))
-   **eslint-plugin:** \[no-deprecated] not reporting usages of deprecated declared constants as object value ([#10498](typescript-eslint/typescript-eslint#10498))

##### ❤️ Thank You

-   Luke Deen Taylor [@controversial](https://github.com/controversial)
-   Ronen Amiel
-   Scott O'Hara
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)
-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-condition] regression with types that include undefined under noUncheckedIndexedAccess
2 participants
@yeonjuan @JoshuaKGoldberg
0