8000 docs(eslint-plugin): add docs on using Prettier with the plugin by j-f1 · Pull Request #104 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

docs(eslint-plugin): add docs on using Prettier with the plugin #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 30, 2019
Merged

docs(eslint-plugin): add docs on using Prettier with the plugin #104

merged 6 commits into from
Jan 30, 2019

Conversation

j-f1
Copy link
Contributor
@j-f1 j-f1 commented Jan 21, 2019 •
edited
Loading

BLOCKED on eslint-config-prettier@4 being released.

@j-f1 j-f1 added the DO NOT MERGE PRs which should not be merged yet label Jan 21, 2019
@j-f1 j-f1 force-pushed the eslint-config-prettier branch from a30623f to d30055c Compare January 21, 2019 12:40
@j-f1 j-f1 changed the title docs: add docs on using Prettier with the plugin docs(eslint-plugin): add docs on using Prettier with the plugin Jan 21, 2019
JamesHenry
JamesHenry reviewed Jan 21, 2019
View reviewed changes
bradzacher
bradzacher previously approved these changes Jan 22, 2019
View reviewed changes
armanio123 pushed a commit to armanio123/typescript-eslint that referenced this pull request Jan 24, 2019
@scottohara @JamesHenry
Update: explicit-member-accessibility only check *.ts and *.tsx files (…
5ed8a4a 
…Fixes typescript-eslint#102) (typescript-eslint#104)

* Only check *.ts and *.tsx files (Fixes typescript-eslint#102)

* Move duplicated isTypescript() function to util.js

* Simplify regex in isTypescript()
JamesHenry
JamesHenry requested changes Jan 28, 2019
View reviewed changes
Copy link
Member
@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-f1 I believe 4.x is out now, so we just need to resolve the conflicts :)

@JamesHenry JamesHenry removed the DO NOT MERGE PRs which should not be merged yet label Jan 28, 2019
JamesHenry
JamesHenry previously approved these changes Jan 30, 2019
View reviewed changes
@JamesHenry
Copy link
Member

I had some time, so I fixed the conflicts

@JamesHenry JamesHenry merged commit c779ad4 into master Jan 30, 2019
@JamesHenry JamesHenry deleted the eslint-config-prettier branch January 30, 2019 13:25
@j-f1
Copy link
Contributor Author
j-f1 commented Jan 30, 2019

Sorry for not getting back to you. I was sick this weekend so I’m still working on my notification backlog.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry left review comments

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-f1 @JamesHenry @bradzacher
0