-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs(eslint-plugin): add docs on using Prettier with the plugin #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an is 8000 sue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a30623f
to
d30055c
Compare
JamesHenry
reviewed
Jan 21, 2019
bradzacher
previously approved these changes
Jan 22, 2019
armanio123
pushed a commit
to armanio123/typescript-eslint
that referenced
this pull request
Jan 24, 2019
…Fixes typescript-eslint#102) (typescript-eslint#104) * Only check *.ts and *.tsx files (Fixes typescript-eslint#102) * Move duplicated isTypescript() function to util.js * Simplify regex in isTypescript()
JamesHenry
requested changes
Jan 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j-f1 I believe 4.x is out now, so we just need to resolve the conflicts :)
JamesHenry
previously approved these changes
Jan 30, 2019
I had some time, so I fixed the conflicts |
Sorry for not getting back to you. I was sick this weekend so I’m still working on my notification backlog. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOCKED oneslint-config-prettier@4
being released.