8000 Repo: CI failures on main around prefer-template · Issue #9794 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: CI failures on main around prefer-template #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Aug 14, 2024 · 1 comment
Closed

Repo: CI failures on main around prefer-template #9794

JoshuaKGoldberg opened this issue Aug 14, 2024 · 1 comment
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Following #9544, https://github.com/typescript-eslint/typescript-eslint/actions/runs/10391681549/job/28775306777:

/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin/src/rules/no-unnecessary-template-expression.ts
   21:21  error  Unexpected string concatenation  prefer-template
  180:19  error  Unexpected string concatenation  prefer-template

Sweet irony 😄. cc @abrahamguo, it's from us not requiring branches be up-to-date when merged from main. I'll send a quick commit to fix it.

💖
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Aug 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 14, 2024
JoshuaKGoldberg added a commit to JoshuaKGoldberg/typescript-eslint that referenced this issue Aug 14, 2024
@JoshuaKGoldberg
chore(eslint-plugin): fix prefer-template reports on main
037d3ff 
Fixes typescript-eslint#9794
@JoshuaKGoldberg
Copy link
Member Author
JoshuaKGoldberg commented Aug 14, 2024 •
edited
Loading

Fixed by 3e1ddb0.

This was referenced Aug 14, 2024
Merged
Merged
JoshuaKGoldberg added a commit to JoshuaKGoldberg/typescript-eslint that referenced this issue Aug 14, 2024
@JoshuaKGoldberg
chore(eslint-plugin): fix prefer-template reports on main
3e1ddb0 
Fixes typescript-eslint#9794
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Aug 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
2BA4 @JoshuaKGoldberg
0