8000 Enhancement: Default allowAutomaticSingleRunInference to true in v6 · Issue #6176 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Enhancement: Default allowAutomaticSingleRunInference to true in v6 #6176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
JoshuaKGoldberg opened this issue Dec 7, 2022 · 2 comments
Closed
4 tasks done

Enhancement: Default allowAutomaticSingleRunInference to true in v6 #6176

JoshuaKGoldberg opened this issue Dec 7, 2022 · 2 comments
Labels
breaking change This change will require a new major version to be released enhancement New feature or request performance Issues regarding performance triage Waiting for team members to take a look

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

typescript-estree

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Since #3512 -> #3528 added the opt-in allowAutomaticSingleRunInference, there have been relatively few changes to the flag. AFAIK the only bugs reported have been:

Shoutout @aaronadamsCA for reporting 2/3 of those! 😄

It seems to me like the flag is pretty stable. Since we'll be asking the public to test out the upcoming v6 major version Soon™️, that new version seems like a good time to make allowAutomaticSingleRunInference opt-in as a breaking change.

Fail

n/a

Pass

n/a

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request triage Waiting for team members to take a look breaking change This change will require a new major version to be released performance Issues regarding performance labels Dec 7, 2022
@bradzacher
Copy link
Member

It's a bit funky with --fix from what I've noticed.
The fix re-runs won't have proper type information so rules like the no-unsafe-* rules will report false errors on fixed files that won't show up on a non-fixing run.

We need to figure out a better solution for the fix case before we can really roll this out to everyone I think, or else we'll create a really flaky and confusing experience.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 7, 2022
Closed
3 tasks
@JoshuaKGoldberg
Copy link
Member Author

Got it - I'll close this and file a separate bug. Thanks!

This was referenced Dec 8, 2022
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released enhancement New feature or request performance Issues regarding performance triage Waiting for team members to take a look
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @bradzacher
0