8000 fix(typescript-estree): ensure --fix works with singleRun mode by JamesHenry · Pull Request #3655 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(typescript-estree): ensure --fix works with singleRun mode #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2021
Merged

fix(typescript-estree): ensure --fix works with singleRun mode #3655

merged 3 commits into from
Aug 2, 2021

Conversation

JamesHenry
Copy link
Member
@JamesHenry JamesHenry commented Jul 23, 2021 •
edited
Loading

I realise this isn't the most sophisticated fix (and we can improve this further in the future by adding support for the catch-all builder program as we discussed as part of the long-term solution to createDefaultProgram) but for now this at least makes singleRun mode usable with --fix and in my basic testing locally it still yields a speed up over the same invocation without singleRun mode enabled.

Fixes #3626

@JamesHenry JamesHenry added bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree labels Jul 23, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JamesHenry JamesHenry mentioned this pull request Jul 23, 2021
Closed
3 tasks
@nx-cloud
Copy link
nx-cloud bot commented Jul 23, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 7393883. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry force-pushed the single-run-fix-mode branch from 86d0703 to 49c3524 Compare July 23, 2021 12:56
@codecov
Copy link
codecov bot commented Jul 23, 2021 •
edited
Loading

Codecov Report

Merging #3655 (7393883) into master (84fff35) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3655      +/-   ##
==========================================
+ Coverage   92.64%   92.68%   +0.04%     
==========================================
  Files         326      325       -1     
  Lines       11253    11344      +91     
  Branches     3171     3201      +30     
==========================================
+ Hits        10425    10514      +89     
- Misses        368      369       +1     
- Partials      460      461       +1
Flag Coverage Δ
unittest 92.68% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/node-utils.ts 97.83% <0.00%> (ø)
packages/typescript-estree/src/simple-traverse.ts 75.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-loss-of-precision.ts 91.66% <0.00%> (ø)
...tal-utils/src/ast-utils/eslint-utils/predicates.ts 100.00% <0.00%> (ø)
packages/visitor-keys/src/visitor-keys.ts
packages/visitor-keys/src/get-keys.ts
...eslint-plugin/src/rules/prefer-return-this-type.ts 90.47% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 93.93% <0.00%> (+0.18%) ⬆️
...pt-estree/src/create-program/createWatchProgram.ts 77.27% <0.00%> (+0.23%) ⬆️
packages/eslint-plugin/src/rules/return-await.ts 97.02% <0.00%> (+1.15%) ⬆️
... and 6 more

uniqueiniquity
uniqueiniquity previously approved these changes Jul 23, 2021
View reviewed changes
bradzacher
bradzacher previously approved these changes Aug 1, 2021
View reviewed changes
@JamesHenry JamesHenry dismissed stale reviews from bradzacher and uniqueiniquity via 7393883 August 2, 2021 08:17
@JamesHenry JamesHenry merged commit 99eca0d into master Aug 2, 2021
@JamesHenry JamesHenry deleted the single-run-fix-mode branch August 2, 2021 08:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

@uniqueiniquity uniqueiniquity uniqueiniquity left review comments

Assignees
No one assigned
Labels
bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[allowAutomaticSingleRunInference] auto fix mangles files
3 participants
@JamesHenry @bradzacher @uniqueiniquity
0