8000 Docs/Naming: Standardize on "Promise" or "Thenable" in rule names · Issue #5946 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content
Docs/Naming: Standardize on "Promise" or "Thenable" in rule names #5946
Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

One rule directly refers to Thenables:

Other rules refer to Promises:

IMO it's confusing how only one rule refers to Thenables... even though that's technically the correct term.

Thoughts: should we rename some rule(s) for clarity vs. discoverability? I haven't re-looked deeply into the rules, but if no-floating-promises & no-misused-promises actually work on all Thenables (and not just Promises) then maybe we should call them all thenables? Or maybe most users don't know what a Thenable is, and we should always say Promises?

Affected URL(s)

https://typescript-eslint.io/rules/

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationDocumentation ("docs") that needs adding/updatingtriageWaiting for team members to take a look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0