8000 Repo: Speed up semantic-breaking-change-pr.yml · Issue #11206 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content
Repo: Speed up semantic-breaking-change-pr.yml #11206
Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Suggestion

Splitting out of #11204: our semantic-breaking-change-pr.yml workflow is good and useful for making sure PRs that introduce breaking changes have the appropriate title and description.

But, per https://github.com/typescript-eslint/typescript-eslint/actions/metrics/usage, that action currently is our third biggest slice of total CI minutes. I'm seeing 613 minutes across 359 runs over the last month.

Much of that time comes from the action having to go through our full installation command:

- uses: ./.github/actions/prepare-install

Let's speed that up! I can think of a couple options to try:

  • Quick & easy: Instead of our shared installation action, we could install just the @github/* deps the JS file actually uses
  • More comprehensive: @bradzacher suggested internally that we could switch it to a standalone repo's action. Doing so would allow us to pre-compile the action as JS and make it reusable

Proposal: let's go with quick & easy for now?

Additional Info

Also related is #11205, for speeding up CI install times. But I don't think this workflow should be running a full repository install at all.

💖

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.performanceIssues regarding performancerepo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0