10000 Indentation warning for properties of argument object · Issue #11 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content
8000

Indentation warning for properties of argument object #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JamesHenry opened this issue Jan 15, 2019 · 1 comment
Closed

Indentation warning for properties of argument object #11

JamesHenry opened this issue Jan 15, 2019 · 1 comment
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@JamesHenry
Copy link
Member

This issue was initially reported here: eslint/typescript-eslint-parser#458

What version of TypeScript are you using?
2.7.1

What version of typescript-eslint-parser are you using?
14.0.0

What code were you trying to parse?

const registration = (
  state: RegistrationStoreState = initialState,
  action: {
    type: string;
    data: Object;
    error: Object;
  }
) => {
...
}

What did you expect to happen?
To see clear worskpace without warning

What happened?

I see warning [eslint] Expected indentation of 2 spaces but found 4. (indent)
And only when I format this code in this way:


const registration = (
  state: RegistrationStoreState = initialState,
  action: {
  type: string;
  data: Object;
  error: Object;
  }
) => {
...
}

I don't see warnings.
@JamesHenry JamesHenry mentioned this issue Jan 15, 2019
Closed
JamesHenry pushed a commit that referenced this issue Jan 17, 2019
@greenkeeper @JamesHenry
chore(package): Update eslint to version 4.12.1 (#11)
04e6f39
JamesHenry pushed a commit that referenced this issue Jan 17, 2019
@semantic-release-bot @JamesHenry
chore(release): 2.2.0 [skip ci]
ddc30fe 
## 2.2.0 (2018-08-25)

* ci: Added missing packages ([3938da6](unlight/eslint-plugin-tslint2@3938da6))
* ci(.travis.yml): Add greenkeeper-lockfile support (#7) ([706d9d6](unlight/eslint-plugin-tslint2@706d9d6)), closes [#7](https://github.com/unlight/eslint-plugin-tslint2/issues/7)
* Merge branch 'dev' ([db9bf0e](unlight/eslint-plugin-tslint2@db9bf0e))
* docs: Updated README ([b6947be](unlight/eslint-plugin-tslint2@b6947be))
* chore: Disabled package-lock ([07fa1d6](unlight/eslint-plugin-tslint2@07fa1d6))
* chore: Removed old infrastructure code ([43f5b4e](unlight/eslint-plugin-tslint2@43f5b4e))
* chore(package): Update @types/node to version 8.0.54 ([06c9397](unlight/eslint-plugin-tslint2@06c9397))
* chore(package): Update @types/node to version 8.0.57 (#18) ([719dc89](unlight/eslint-plugin-tslint2@719dc89)), closes [#18](https://github.com/unlight/eslint-plugin-tslint2/issues/18)
* chore(package): Update @types/node to version 8.0.58 (#20) ([a1ed18f](unlight/eslint-plugin-tslint2@a1ed18f)), closes [#20](https://github.com/unlight/eslint-plugin-tslint2/issues/20)
* chore(package): Update eslint to version 4.12.0 (#8) ([041551c](unlight/eslint-plugin-tslint2@041551c)), closes [#8](https://github.com/unlight/eslint-plugin-tslint2/issues/8)
* chore(package): Update eslint to version 4.12.1 (#11) ([5124913](unlight/eslint-plugin-tslint2@5124913)), closes [#11](https://github.com/unlight/eslint-plugin-tslint2/issues/11)
* chore(package): Update eslint to version 4.13.0 (#17) ([2695502](unlight/eslint-plugin-tslint2@2695502)), closes [#17](https://github.com/unlight/eslint-plugin-tslint2/issues/17)
* chore(package): update eslint to version 4.13.1 ([7f1b4fa](unlight/eslint-plugin-tslint2@7f1b4fa))
* chore(package): Update lint-staged to to version 6.0.0 (#12) ([040ec25](unlight/eslint-plugin-tslint2@040ec25)), closes [#12](https://github.com/unlight/eslint-plugin-tslint2/issues/12)
* chore(package): Update prettier-eslint-cli to version 4.4.2 ([2d024f3](unlight/eslint-plugin-tslint2@2d024f3)), closes [#13](https://github.com/unlight/eslint-plugin-tslint2/issues/13)
* chore(package): Update typescript to to version 2.6.2 (#9) ([25661af](unlight/eslint-plugin-tslint2@25661af)), closes [#9](https://github.com/unlight/eslint-plugin-tslint2/issues/9)
* chore(package): Update typescript-eslint-parser to version 10.0.0 (#19) ([4b9230b](unlight/eslint-plugin-tslint2@4b9230b)), closes [#19](https://github.com/unlight/eslint-plugin-tslint2/issues/19)
* chore(package): Update typescript-eslint-parser to version 9.0.1 (#10) ([a39256c](unlight/eslint-plugin-tslint2@a39256c)), closes [#10](https://github.com/unlight/eslint-plugin-tslint2/issues/10)
* chore(README): Banner URL ([d0ac4d2](unlight/eslint-plugin-tslint2@d0ac4d2))
* chore(travis): Whitelist greenkeeper branches (#6) ([4cc915b](unlight/eslint-plugin-tslint2@4cc915b)), closes [#6](https://github.com/unlight/eslint-plugin-tslint2/issues/6)
* refactor: Rewritten always-fail-rule in es2015 style ([651b629](unlight/eslint-plugin-tslint2@651b629))
* style: Changed indent to 4 spaces ([bfa7756](unlight/eslint-plugin-tslint2@bfa7756))
* feat(core): Added support rules requires type information ([6bc1deb](unlight/eslint-plugin-tslint2@6bc1deb)), closes [#32](https://github.com/unlight/eslint-plugin-tslint2/issues/32) [#34](https://github.com/unlight/eslint-plugin-tslint2/issues/34)
JamesHenry pushed a commit that referenced this issue Jan 17, 2019
@greenkeeper @JamesHenry
chore(package): Update eslint to version 4.12.1 (#11)
a92b8f3
JamesHenry pushed a commit that referenced this issue Jan 17, 2019
@semantic-release-bot @JamesHenry
chore(release): 2.2.0 [skip ci]
92ab381 
## 2.2.0 (2018-08-25)

* ci: Added missing packages ([3938da6](unlight/eslint-plugin-tslint2@3938da6))
* ci(.travis.yml): Add greenkeeper-lockfile support (#7) ([706d9d6](unlight/eslint-plugin-tslint2@706d9d6)), closes [#7](https://github.com/unlight/eslint-plugin-tslint2/issues/7)
* Merge branch 'dev' ([db9bf0e](unlight/eslint-plugin-tslint2@db9bf0e))
* docs: Updated README ([b6947be](unlight/eslint-plugin-tslint2@b6947be))
* chore: Disabled package-lock ([07fa1d6](unlight/eslint-plugin-tslint2@07fa1d6))
* chore: Removed old infrastructure code ([43f5b4e](unlight/eslint-plugin-tslint2@43f5b4e))
* chore(package): Update @types/node to version 8.0.54 ([06c9397](unlight/eslint-plugin-tslint2@06c9397))
* chore(package): Update @types/node to version 8.0.57 (#18) ([719dc89](unlight/eslint-plugin-tslint2@719dc89)), closes [#18](https://github.com/unlight/eslint-plugin-tslint2/issues/18)
* chore(package): Update @types/node to version 8.0.58 (#20) ([a1ed18f](unlight/eslint-plugin-tslint2@a1ed18f)), closes [#20](https://github.com/unlight/eslint-plugin-tslint2/issues/20)
* chore(package): Update eslint to version 4.12.0 (#8) ([041551c](unlight/eslint-plugin-tslint2@041551c)), closes [#8](https://github.com/unlight/eslint-plugin-tslint2/issues/8)
* chore(package): Update eslint to version 4.12.1 (#11) ([5124913](unlight/eslint-plugin-tslint2@5124913)), closes [#11](https://github.com/unlight/eslint-plugin-tslint2/issues/11)
* chore(package): Update eslint to version 4.13.0 (#17) ([2695502](unlight/eslint-plugin-tslint2@2695502)), closes [#17](https://github.com/unlight/eslint-plugin-tslint2/issues/17)
* chore(package): update eslint to version 4.13.1 ([7f1b4fa](unlight/eslint-plugin-tslint2@7f1b4fa))
* chore(package): Update lint-staged to to version 6.0.0 (#12) ([040ec25](unlight/eslint-plugin-tslint2@040ec25)), closes [#12](https://github.com/unlight/eslint-plugin-tslint2/issues/12)
* chore(package): Update prettier-eslint-cli to version 4.4.2 ([2d024f3](unlight/eslint-plugin-tslint2@2d024f3)), closes [#13](https://github.com/unlight/eslint-plugin-tslint2/issues/13)
* chore(package): Update typescript to to version 2.6.2 (#9) ([25661af](unlight/eslint-plugin-tslint2@25661af)), closes [#9](https://github.com/unlight/eslint-plugin-tslint2/issues/9)
* chore(package): Update typescript-eslint-parser to version 10.0.0 (#19) ([4b9230b](unlight/eslint-plugin-tslint2@4b9230b)), closes [#19](https://github.com/unlight/eslint-plugin-tslint2/issues/19)
* chore(package): Update typescript-eslint-parser to version 9.0.1 (#10) ([a39256c](unlight/eslint-plugin-tslint2@a39256c)), closes [#10](https://github.com/unlight/eslint-plugin-tslint2/issues/10)
* chore(README): Banner URL ([d0ac4d2](unlight/eslint-plugin-tslint2@d0ac4d2))
* chore(travis): Whitelist greenkeeper branches (#6) ([4cc915b](unlight/eslint-plugin-tslint2@4cc915b)), closes [#6](https://github.com/unlight/eslint-plugin-tslint2/issues/6)
* refactor: Rewritten always-fail-rule in es2015 style ([651b629](unlight/eslint-plugin-tslint2@651b629))
* style: Changed indent to 4 spaces ([bfa7756](unlight/eslint-plugin-tslint2@bfa7756))
* feat(core): Added support rules requires type information ([6bc1deb](unlight/eslint-plugin-tslint2@6bc1deb)), closes [#32](https://github.com/unlight/eslint-plugin-tslint2/issues/32) [#34](https://github.com/unlight/eslint-plugin-tslint2/issues/34)
@JamesHenry JamesHenry added the package: parser Issues related to @typescript-eslint/parser label Jan 18, 2019
@bradzacher bradzacher added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin migration-test and removed package: parser Issues related to @typescript-eslint/parser labels Jan 18, 2019
@armano2
Copy link
Collaborator
armano2 commented Jan 19, 2019

@bondom this issue is no longer present if you use eslint-plugin-typescript indent rule

we have test scenario for this already

@armano2 armano2 closed this as completed Jan 19, 2019
@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@armano2 @JamesHenry @bradzacher
0