8000 Bug: [no-invalid-void-type] should report `accessor` properties with an invalid `void` type · Issue #10843 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Bug: [no-invalid-void-type] should report accessor pr 8000 operties with an invalid void type #10843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
ronami opened this issue Feb 17, 2025 · 1 comment · Fixed by #10864
Closed
4 tasks done

Bug: [no-invalid-void-type] should report accessor properties with an invalid void type #10843

ronami opened this issue Feb 17, 2025 · 1 comment · Fixed by #10864
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@ronami
Copy link
Member
ronami commented Feb 17, 2025 •
edited
Loading

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.ts&code=MYGwhgzhAEAqCmEAuBGaBvAUNaB6X0ATvAA4D2hS8AJtMBccEiAJ7bQmFkkByYAtvABc0AG5kAltQDcmAL6ZMoSDATIATBnb5oEABZkAriFoAjeEVIUqZw0mjUyiAHYByJOzDBgiCBQ5cvALCYpIy8phAA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1uYDcBDRgBNaPDpWFFS6KImjQO0SODABfECqA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

class Test1 {
  // reported correctly
  propName: void;
}

class Test2 {
  // should be reported but doesn't
  accessor propName: void;
}

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/no-invalid-void-type": "error",
  },
};

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

I expected the rule to report on the accessor property, similar to how it reports the standard property.

Actual Result

The accessor property didn't get reported.

Additional Info

Related: #10763 (comment), one more accessor issue 😅
@ronami ronami 8000 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Feb 17, 2025
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Feb 19, 2025
@JoshuaKGoldberg
Copy link
Member

🫠 so many accessor bugs...

@ronami ronami mentioned this issue Feb 21, 2025
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Mar 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
2 participants
@JoshuaKGoldberg @ronami
0