Bug: [no-inferrable-types] False negatives on auto-accessors #10763

yeonjuan · 2025-02-03T16:29:04Z

Before You File a Bug Report Please Confirm You Have Done The Following...

I have tried restarting my IDE and the issue persists.
I have updated to the latest version of the packages.
I have searched for related issues and found none that matched my issue.
I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.ts&code=FAYwNghgzlAEBiB7RsDexawA4CdFagC5YA7AVwFsAjAUx1gF5YBWAbg1ghBBpkXq48%2BOAAp4CxctTqMW7AL5A&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1uYDNFpoAQwBGSWkVKoMkftA7RI4MAF8QyoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

class Foo {
  props: number = 5; // Error (ok)
  accessor accessorProps: number = 5; // No Error (false negative)
}

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
     "@typescript-eslint/no-inferrable-types": "error"
  },
};

tsconfig

{
  "compilerOptions": {
    // ...
  }
}

Expected Result

class Foo {
  props: number = 5; // Error
  accessor accessorProps: number = 5; // Error
}

Actual Result

class Foo {
  props: number = 5; // Error
  accessor accessorProps: number = 5; // No Error
}

Additional Info

No response

ronami · 2025-02-03T16:48:01Z

This seems like a bug to me, as the type remains the same with or without the annotation (playground link). I think this is a pretty straightforward fix.

ronami · 2025-02-04T19:39:10Z

I was thinking about this some more: I think that missing accessor handling seems pretty common because it's a different AST node rather than an attribute (like readonly). I did a quick search and I think I found six additional bugs with six different rules:

explicit-module-boundary-types (playground link)
prefer-return-this-type (playground link)
no-unsafe-assignment (playground link)
explicit-member-accessibility (playground link)
consistent-generic-constructors (playground link)
class-methods-use-this (playground link)

I'll open an issue for each of these 🙃

yeonjuan added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Feb 3, 2025

ronami added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Feb 3, 2025

yeonjuan mentioned this issue Feb 4, 2025

fix(eslint-plugin): [no-inferrable-types] handle accessor #10780

Merged

3 tasks

JoshuaKGoldberg closed this as completed in #10780 Feb 15, 2025

ronami mentioned this issue Feb 17, 2025

Bug: [no-invalid-void-type] should report accessor properties with an invalid void type #10843

Closed

4 tasks

github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Feb 23, 2025

github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: [no-inferrable-types] False negatives on auto-accessors #10763

Bug: [no-inferrable-types] False negatives on auto-accessors #10763

Bug: [no-inferrable-types] False negatives on auto-accessors #10763

Bug: [no-inferrable-types] False negatives on auto-accessors #10763

Comments

Before You File a Bug Report Please Confirm You Have Done The Following...

Playground Link

Repro Code

ESLint Config

tsconfig

Expected Result

Actual Result

Additional Info