8000 Bug: [no-misused-promises] should not report `static` `accessor` properties with a function initializer · Issue #10812 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Bug: [no-misused-promises] should not report static accessor properties with a function initiali 8000 zer #10812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
ronami opened this issue Feb 7, 2025 · 0 comments · Fixed by #10814
Closed
4 tasks done

Bug: [no-misused-promises] should not report static accessor properties with a function initializer #10812

ronami opened this issue Feb 7, 2025 · 0 comments · Fixed by #10814
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@ronami
Copy link
Member
ronami commented Feb 7, 2025

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.5.2&fileType=.tsx&code=MYGwhgzhAEBCkFMCM0DeBYAUNaAHArgEYgCWw0EA9gLYICyCALgBaUAm0AvNABQCUALmgA3SiQ6cAfGmgBfLPMxZQkGAFEAHowQA7NgjYoEW3WxjwIyNFhwB6W9GCUATs4TBGIAJ7Q2lBBA6AOSM0G64Low2eESk5BCMYIxkFDT0TKwS0JBeOuT8QgAKzjQklgA8ouLSUjKKisrgUHCIAEzW2DHEKVS0DCzsXLyCImIS0qhyCliNqtCa2noG7caLZi2W7Rid9mEIEc6MMIT4oRCs%2BCBswVGdBN3xicnkYMDAAVTOqX0Zg9w5eWGRRK1DKCEqYxqEymmEUQA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oFtLlZkiACa1i0Dr0GoMkRNHHRI4MAF8QKoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

class Base1 {
  public someMethod = (): void => { }
}

class Extended1 extends Base1 {
  // correctly doesn't report
  public static someMethod = async (): Promise<void> => { }
}

class Base2 {
  public someMethod = (): void => { }
}

class Extended2 extends Base2 {
  // reports but shouldn't
  public static accessor someMethod = async (): Promise<void> => { }
}

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/no-misused-promises": "error",
  },
};

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

I expected the rule not to report this, similar to how it treats standard static properties.

Actual Result

The rule reported the static accessor property, which I think is a false-positive.

Additional Info

Related: #10763 (comment).
@ronami ronami added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Feb 7, 2025
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Feb 7, 2025
@ronami ronami mentioned this issue Feb 7, 2025
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Feb 25, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
2 participants
@ronami @bradzacher
0