8000 Repo: Bump yarn to v4 · Issue #10380 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: Bump yarn to v4 #10380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trivikr opened this issue Nov 24, 2024 · 5 comments
Closed

Repo: Bump yarn to v4 #10380

trivikr opened this issue Nov 24, 2024 · 5 comments
Assignees
@JamesHenry
Labels
blocked by another PR PRs which are ready to go but waiting on another PR locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@trivikr
Copy link
Contributor
trivikr commented Nov 24, 2024

Suggestion

Yarn v4 was released in on Oct 22, 2023, and this repo can upgrade to it.

Upgrade to yarn v3 was done in #6162 in Dec 2022.

Additional Info

Looks like maintainers just need to check a checkbox on #6687, and renovate will create a PR to upgrade.
@trivikr trivikr added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look labels Nov 24, 2024
@bradzacher
Copy link
Member
bradzacher commented Nov 24, 2024 •
edited
Loading

Is there any tangible benefit to us to upgrading? Just curious if there's some must have feature?

@trivikr
Copy link
Contributor Author
trivikr commented Nov 24, 2024

The benefits depends on how your development tooling it set up. The blog post has details.

I really liked that yarn v4 official plugins, especially interactive-tools, by default.
The extra validations under hardened mode are also helpful. Also comes with faster installs.

@JoshuaKGoldberg
Copy link
Member

just need to check a checkbox

The Arbiter in Halo 3 saying to Lord Hood: "were it so easy"

@JamesHenry is working on a bunch of infrastructure things around our TSConfig setup. It's probably safest to tentatively assign this to James for now (at least to triage what should be done), and mark it as blocked on #10361.

Thanks for filing - I think in general it's nice to be on the latest of things if possible!

@JoshuaKGoldberg JoshuaKGoldberg added blocked by another PR PRs which are ready to go but waiting on another PR and removed triage Waiting for team members to take a look labels Nov 24, 2024
@trivikr
Copy link
Contributor Author
trivikr commented Nov 25, 2024

I think Renovate will upgrade yarn to v4, but will keep existing setup - i.e. binary from yarnPath and explicitly added plugins.
The removal of official plugins can be done in the same, or different PR. The binary can also be removed, if needed.

@JamesHenry
Copy link
Member

We decided we will move to pnpm instead, I have opened #10891 and closing this one in favour of it.

@JamesHenry JamesHenry closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2025
@kirkwaiblinger kirkwaiblinger mentioned this issue Feb 27, 2025
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Mar 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesHenry JamesHenry

Labels
blocked by another PR PRs which are ready to go but waiting on another PR locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JamesHenry @JoshuaKGoldberg @bradzacher @trivikr
0