8000 Added no-unused-expression converter by asponda · Pull Request #205 · typescript-eslint/tslint-to-eslint-config · GitHub
[go: up one dir, main page]
Skip to content

Added no-unused-expression converter #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 7, 2019
Merged

Added no-unused-expression converter #205

merged 8 commits into from
Oct 7, 2019

Conversation

asponda
Copy link
Contributor
@asponda asponda commented Oct 4, 2019

PR Checklist

Overview

Added converter for TSLint rule "no-unused-expression" and unit tests

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 4, 2019
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, but a couple missing TSLint rule options please.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 4, 2019
JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 7, 2019
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Oct 7, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 7, 2019 8000
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just the two small changes! 😀

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious. This rule was a little more complex than it first looked and I appreciate you sticking through with it @asponda. Thanks! 🔥

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6ae5bb7 into typescript-eslint:master Oct 7, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Oct 10, 2019
@rwaskiewicz rwaskiewicz mentioned this pull request May 5, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: no-unused-expression
2 participants
@asponda @JoshuaKGoldberg
0