refactor: unify content of ActionCoords name #1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
02098ce to
37375d9
Compare
krzema12
reviewed
Sep 21, 2024
|
Done |
c1dc24a to
6d56a0d
Compare
krzema12
reviewed
Sep 24, 2024
...main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionCoords.kt
Outdated
Show resolved
Hide resolved
6d56a0d to
1dc7506
Compare
This was referenced Sep 29, 2024
1dc7506 to
c691f60
Compare
c691
8000
f60 to
37ad070
Compare
37ad070 to
52919f6
Compare
krzema12
approved these changes
Oct 27, 2024
| @@ -287,6 +287,30 @@ class GenerationTest : | |||
| binding.shouldContainAndMatchFile("ActionWithNoInputs.kt") | |||
| } | |||
|
|
|||
| test("subaction") { | |||
There was a problem hiding this comment.
Thanks for adding this missing test 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes,
ActionCoords#namesometimes had the actual action coordinates, so for examplesome-name__some-sub, sometimes it had the replacedsome-name/some-sub.This is not good, as you never know what you get and also led to certain bugs where wrong things are written to metadata files for example.
This changes unifies the situation, so that the
nameonly contains the repository name and thepathis in a separate property with slashes.All other manipulation is then done where needed.