8000 feat(abg)!: allow to wire typed outputs to matching typed inputs by Vampire · Pull Request #1624 · typesafegithub/github-workflows-kt · GitHub
[go: up one dir, main page]
Skip to content

feat(abg)!: allow to wire typed outputs to matching typed inputs #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: vampire/binding-version-v2
Choose a base branch
from
Open

feat(abg)!: allow to wire typed outputs to matching typed inputs #1624

wants to merge 1 commit into from

Conversation

Vampire
Copy link
Collaborator
@Vampire Vampire commented Aug 23, 2024 •
edited
Loading

Fixes #73

If types of input and output match, you can do

lookupOnlyExpression = cache.outputs.cacheHit

If types do not match for whatever reason, you can still do

lookupOnlyExpression = cache.outputs.cacheHit_Untyped

or

lookupOnlyExpression = Expression(cache.outputs.cacheHit.expression)

or (but deprecated)

lookupOnly_Untyped = cache.outputs.cacheHit.expressionString

If no type is declared for the output, you can still stuff the _Untyped one into any expression input like

lookupOnlyExpression = cache.outputs.cacheHit_Untyped

Ad-hoc outputs behave like untyped outputs in that you can stuff it into everywhere

lookupOnlyExpression = cache.outputs["cache-hit"]

@Vampire Graphite App
Copy link
Collaborator Author
Vampire commented Aug 23, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch 3 times, most recently from ff26830 to 46ca5ad Compare August 23, 2024 20:34
@Vampire
Copy link
Collaborator Author
Vampire commented Aug 23, 2024 •
edited
Loading

So far it indeed seems to work just great.
I played a bit with the current state, merged with my other stack.

@Vampire
Copy link
Collaborator Author
Vampire commented Aug 23, 2024

Main remaining problem is probably the naming at https://github.com/typesafegithub/github-workflows-kt/pull/1624/files#diff-76c4a08acf57b6c491c34cc60e6ad7bbc219fbd45dc0dda74550941ecac51200 :-/

@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from 46ca5ad to 14d4f80 Compare August 23, 2024 20:44
@Vampire
Copy link
Collaborator Author
Vampire commented Aug 23, 2024

Of course the typing catalog should be polished to have proper output types which it currently does not have.
That's anyway a bit bad, as the typing catalog is supposed to be independent of consumers, so just using string everywhere just because this lib does not yet read it, ..., well, ... ;-)

@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from 14d4f80 to f4b6351 Compare August 23, 2024 21:13
@Vampire Vampire marked this pull request as ready for review August 23, 2024 21:23
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently from 3a53468 to f0429b9 Compare August 25, 2024 02:19
@Vampire Graphite App
Copy link
Collaborator Author
Vampire commented Aug 25, 2024

Forgot the job outputs, now they are also typed :-)

@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch 9 times, most recently from adbea5b to 59626c0 Compare August 31, 2024 18:28
@Vampire Graphite App
Copy link
Collaborator Author
Vampire commented Aug 31, 2024

And now AbstractResult also has a toExpression() function :-)

@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch 4 times, most recently from 90360a0 to 09d160e Compare September 5, 2024 18:48
@Vampire Vampire changed the title feat(abg)!: Allow to wire typed outputs to matching typed inputs feat(abg)!: allow to wire typed outputs to matching typed inputs Sep 5, 2024
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently from d7c1b5d to f3b7790 Compare September 6, 2024 18:43
8000
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch 2 times, most recently from 60da5e6 to 53c27b0 Compare April 30, 2025 18:08
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently from 1c80ac5 to cdeb8d0 Compare May 1, 2025 22:25
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 53c27b0 to c9e8a2f Compare May 1, 2025 22:25
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from cdeb8d0 to da90471 Compare May 1, 2025 23:56
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from c9e8a2f to d0ef59a Compare May 1, 2025 23:56
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from da90471 to 0937347 Compare May 2, 2025 11:16
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from d0ef59a to 1e38b69 Compare May 2, 2025 11:16
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from 0937347 to 8eabe36 Compare May 2, 2025 11:51
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 1e38b69 to 54a0d0e Compare May 2, 2025 11:51
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from 8eabe36 to 3cb4b89 Compare May 2, 2025 12:34
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 54a0d0e to 0af24c3 Compare May 2, 2025 12:34
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from 3cb4b89 to 3fc563c Compare May 4, 2025 18:39
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 0af24c3 to 16cb955 Compare May 4, 2025 18:39
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from 3fc563c to 0dd5cd3 Compare May 6, 2025 13:09
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch 2 times, most recently from 78db07b to 88a11f6 Compare May 12, 2025 12:32
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch 2 times, most recently from 454f1fb to e1487be Compare May 12, 2025 12:39
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch 2 times, most recently from 5b5bb0f to 2974c43 Compare May 12, 2025 15:26
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from e1487be to d077e1e Compare May 12, 2025 15:26
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 2974c43 to 481b627 Compare May 14, 2025 13:23
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from d077e1e to 3cf8517 Compare May 14, 2025 13:23
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from 481b627 to b4d13ce Compare May 20, 2025 09:49
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from 3cf8517 to a32478e Compare May 20, 2025 09:49
@Vampire Vampire force-pushed the vampire/binding-version-v2 branch from b4d13ce to e788dc0 Compare May 20, 2025 10:08
@Vampire Vampire force-pushed the vampire/type-safe-inputs-and-outputs-wiring branch from a32478e to 1239cdc Compare May 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core feature request] Allow passing non-string outputs to inputs
1 participant
@Vampire
0