8000 test: fix duplicate schema test cases by krzema12 · Pull Request #267 · typesafegithub/github-actions-typing · GitHub
[go: up one dir, main page]
Skip to content

test: fix duplicate schema test cases #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

test: fix duplicate schema test cases #267

merged 2 commits into from
Jan 31, 2025

Conversation

krzema12
Copy link
Member
@krzema12 krzema12 commented Jan 31, 2025 •
edited
Loading

@krzema12 krzema12 requested a review from Vampire January 31, 2025 10:36
@krzema12 krzema12 marked this pull request as ready for review January 31, 2025 10:37
@krzema12 krzema12 enabled auto-merge (squash) January 31, 2025 10:38
@krzema12
Copy link
Member Author
krzema12 commented Jan 31, 2025 •
edited
Loading

Actually, there are more duplicates, see:

find src/test/resources | grep ml | xargs md5 -q | sort | uniq -c | sort -n | grep -v " 1 "

   2 05c0e257cca9ac155ed126c46ae96f48
   2 2eb4315c8db50d448a3d3b5fa39fd633
   2 4ef6fd5770dbc066e09a49c0dc0ee507
   2 6718ec432c8b7aece74fffff8c6dc3f8
   2 6e2d64b66c2e654c0ed7542d5ea65e5a
   2 b3bfc34a9a5e3e11ea9f06d1a1618f81
   2 c36cc4f2167661afaa276f16293d6091
   2 e4a52db559ad8ccb6dc99e40aa194c5e

@krzema12 krzema12 disabled auto-merge January 31, 2025 10:53
@krzema12 krzema12 changed the title test: fix test cases for integer with non-integer named values test: fix duplcate schema test cases Jan 31, 2025
@krzema12 krzema12 marked this pull request as draft January 31, 2025 10:54
@krzema12 krzema12 removed the request for review from Vampire January 31, 2025 10:54
@krzema12 krzema12 requested a review from Vampire January 31, 2025 11:01
@krzema12 krzema12 marked this pull request as ready for review January 31, 2025 11:01
@krzema12 krzema12 changed the title test: fix duplcate schema test cases test: fix duplicate schema test cases Jan 31, 2025
@krzema12 krzema12 mentioned this pull request Jan 31, 2025
Merged
@Vampire Graphite App
Copy link
Collaborator
Vampire commented Jan 31, 2025

Stange, let me have a look when I'm at home, I'm on mobile right now. There should not be duplicates. The example you posted is different, inputs vs. outputs

@Vampire Graphite App
Copy link
Collaborator
Vampire commented Jan 31, 2025

But from a quick look on mobile I think I agree that this was bad copy & paste and the changes are fine.

@krzema12
Copy link
Member Author

Ok, let me merge and we can always adjust.

@krzema12 krzema12 merged commit 019e6bd into main Jan 31, 2025
4 checks passed
@krzema12 krzema12 deleted the fix-failing-test-cases-for-integer-with-non-integer-named-value branch January 31, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vampire Vampire Awaiting requested review from Vampire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzema12 @Vampire
0