8000 chore: move schema to repo root by krzema12 · Pull Request #254 · typesafegithub/github-actions-typing · GitHub
[go: up one dir, main page]
Skip to content

chore: move schema to repo root #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2025
Merged

chore: move schema to repo root #254

merged 4 commits into from
Jan 29, 2025

Conversation

krzema12
Copy link
Member

apart from the visibility, let me share some more thoughts. I'm looking at the path: src/main/schema - schema is fine, but src/main is kinda Gradle-ish... it's not that I don't want to use Gradle anymore, but I wouldn't couple the location of the schema to this convention, so the first change would be src/main/schema -> schema . Next, if there's just a single file (and there's really no point in having more in the future, right?), why should it live in the schema directory? That's why I thought of the root dir

@krzema12 krzema12 requested a review from Vampire January 29, 2025 10:31
@krzema12 krzema12 merged commit fe2b20a into main Jan 29, 2025
4 checks passed
@krzema12 krzema12 deleted the move-schema-to-repo-root branch January 29, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vampire Vampire Awaiting requested review from Vampire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krzema12
0