10000 Generate `dist` catalog only for releases · Issue #211 · typesafegithub/github-actions-typing · GitHub
[go: up one dir, main page]
Skip to content

Generate dist catalog only for releases #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krzema12 opened this issue Aug 28, 2024 · 2 comments
Closed

Generate dist catalog only for releases #211

krzema12 opened this issue Aug 28, 2024 · 2 comments
Assignees
@krzema12

Comments

@krzema12
Copy link
Member
krzema12 commented Aug 28, 2024 •
edited
Loading

Currently, we keep the dist catalog containing all JARs on the main branch, which means that:

  • it's more problematic for contributors (and me as a maintainer) to make changes because most of them require regenerating the dist directory with a special workflow (or manually)
  • Renovate cannot automatically merge the PRs

The idea is to generate this directory only for releases. We could have a workflow that is run on main and:

  • creates a commit with the dist directory, and pushes it
  • creates a tag with the requested name, and pushes it
  • creates a GitHub release
@krzema12 krzema12 self-assigned this Aug 28, 2024
@krzema12 krzema12 mentioned this issue Aug 28, 2024
Merged
krzema12 added a commit that referenced this issue Aug 28, 2024
@krzema12
Remove dist directory (#212)
fb234c3 
Part of #211.
@krzema12 krzema12 mentioned this issue Aug 28, 2024
Merged
krzema12 added a commit that referenced this issue Aug 28, 2024
@krzema12
Create workflow for releasing (#213)
5ff1deb 
Part of #211.
@krzema12
Copy link
Member Author

The main part is generally done, what's left is:

  • setting the major version tag to the same commit that has just been marked with the patch version tag
  • optionally, creating a GitHub release

@krzema12 krzema12 removed their assignment Sep 24, 2024
@krzema12 krzema12 self-assigned this Oct 13, 2024
@krzema12 krzema12 mentioned this issue Oct 13, 2024
Merged
krzema12 added a commit that referenced this issue Oct 13, 2024
@krzema12
Update major version tag upon releasing (#222)
3d54a0d 
Part of #211.
@krzema12
Copy link
Member Author

Updating major version branch works. Let's keep creating the releases manual for now, I want to have full control over the text there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzema12 krzema12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krzema12
0