Bump python_requires to 3.5.3 for typing.Type and to 3.5.4 for the lowest avaiable python on GHA #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiroiban
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Looks good. Thanks. Nothing major here.
I have a suggestion for a release note so that it will not read less like a commit message :) but nothing major.
If we decide to go for 3.5.3 as the minimum, I think that GitHub Actions should be updated to use that version.
Otherwise, why not go with 3.5.4? as this is the version used on Azure Windows tests
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index ef83fd47e..c1368bde8 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -15,7 +15,7 @@ jobs:
TOXENV: "alldeps-withcov-posix,coverage-prepare,codecov-push,coveralls-push"
strategy:
matrix:
- python-version: [3.5, 3.6, 3.7, 3.8, 3.9, pypy-3.6, pypy-3.7]
+ python-version: [3.5.3, 3.6, 3.7, 3.8, 3.9, pypy-3.6, pypy-3.7]
steps:
- uses: actions/checkout@v2
Please check the comments and merge as you think it's best :)
Thanks!
graingert
commented
Feb 26, 2021
graingert
commented
Feb 26, 2021
graingert
commented
Feb 26, 2021
5 tasks
|
@graingert can you answer the question that @glyph asked you here: https://twistedmatrix.com/pipermail/twisted-python/2021-February/065432.html , preferably sending your answer to the mailing list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
typing.Type[str]doesn't work on py3.5.2 fixed in python 3.5.3 python/typing#267Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standardreviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.