8000 Replace UrlOverride with BaseUrlOverride by Swimburger · Pull Request #84 · twilio-labs/twilio-aspnet · GitHub
[go: up one dir, main page]
Skip to content

Replace UrlOverride with BaseUrlOverride #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking &l 8000 dquo;Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2022
Merged

Replace UrlOverride with BaseUrlOverride #84

merged 2 commits into from
Aug 4, 2022

Conversation

Swimburger
Copy link
Contributor

UrlOverride doesn't make sense to configure at the project level, so I changed it to BaseUrlOverride.
The BaseUrlOverride property will override the URL as before, but append the path of the current HTTP request.
This way you can configure the BaseUrlOverride for the whole project without specifying the individual paths of MVC actions.

This was test for .NET 6, but I need to switch machines to test on Windows.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@Swimburger < 8000 a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/Swimburger/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/Swimburger">Swimburger requested a review from dprothero August 3, 2022 21:17
@Swimburger Swimburger self-assigned this Aug 3, 2022
@Swimburger Swimburger marked this pull request as ready for review August 3, 2022 22:06
dprothero
dprothero approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator
@dprothero dprothero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know when you've published a package and I'll test it out.

@Swimburger Swimburger merged commit aa9c05b into main Aug 4, 2022
@Swimburger Swimburger deleted the base-url-override branch August 4, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprothero dprothero dprothero approved these changes

Assignees

@Swimburger Swimburger

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swimburger @dprothero
0