Add status_callback_url to PhoneNumber.update() #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StatusCallback property of phone numbers is unique in that it specifies a URL, but the property name does not end in "Url" like VoiceUrl, VoiceFallbackUrl, SmsUrl, and SmsFallbackUrl do. As a convenience, the purchase method of PhoneNumbers automatically assigns any status_callback_url argument to the StatusCallback property. This change adds the same convenience to the update method of PhoneNumber.
|
+1 |
1 similar comment
|
+1 |
gbin
added a commit
that referenced
this pull request
Jan 5, 2013
Add status_callback_url to PhoneNumber.update()
|
hm. If you specify neither what is the API behavior? i believe we would send StatusCallback=None to the API which may get rejected because None is not a valid URL. |
eq19
pushed a commit
to VirtualNetworks/parser
that referenced
this pull request
May 1, 2025
(twilio#88) - Fix nodejs check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StatusCallback property of phone numbers is unique in that it
specifies a URL, but the property name does not end in "Url" like
VoiceUrl, VoiceFallbackUrl, SmsUrl, and SmsFallbackUrl do. As a
convenience, the purchase method of PhoneNumbers automatically
assigns any status_callback_url argument to the StatusCallback
property. This change adds the same convenience to the update
method of PhoneNumber.