chore: use older verison of aiohttp_retry #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiwarishubham635
approved these changes
Oct 28, 2024
|
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Nov 21, 2024
Also skips failing units caused by bug in `aiohttp-retry` See twilio/twilio-python#819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://github.com/inyutin/aiohttp_retry/
has released a latest version because of that we are getting error in our sdk build pipeline.
`
self = <aiohttp_retry.client._RequestContext object at 0x7f4176598d90>
| current_attempt = 1
| response = <tests.unit.http.test_async_http_client.MockResponse object at 0x7f4176516c50>
|
| async def _is_skip_retry(self, current_attempt: int, response: ClientResponse) -> bool:
| if current_attempt == self._retry_options.attempts:
| return True
|
| > if response.method not in self._retry_options.methods:
| E AttributeError: 'MockResponse' object has no attribute 'method'
`
Fix:
Using older version and created an issue in aiohttp_retry repo.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.