10000 feat: add details to TwilioRestException by ashish-s · Pull Request #517 · twilio/twilio-python · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ashish-s
Copy link
Contributor
@ashish-s ashish-s commented Apr 21, 2020

Feature

Add a new property named details to RestException. Details is returned by selective apis to populate extra information about errors.
The Studio V2 flow api will be returning extra details with flow validation errors.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link
Contributor
@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a test.

Also, not sure if needed, but current errors print out as follows (source):
Screen Shot 2020-04-23 at 4 26 28 PM

@ashish-s
Copy link
Contributor Author

@thinkingserious added a unit test for rest exception

@childish-sambino childish-sambino merged commit 1a0d02d into twilio:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0