8000 Migrate the README to markdown by childish-sambino · Pull Request #463 · twilio/twilio-python · GitHub
[go: up one dir, main page]

Skip to content

Migrate the README to markdown #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. 8000 We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Migrate the README to markdown #463

merged 2 commits into from
Apr 22, 2019

Conversation

childish-sambino
Copy link
Contributor
@childish-sambino childish-sambino commented Apr 18, 2019

PyPI guide: https://packaging.python.org/guides/making-a-pypi-friendly-readme/
Sphinx Markdown support guide: http://www.sphinx-doc.org/en/master/usage/markdown.html

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Install from PyPi using [pip](http://www.pip-installer.org/en/latest/), a
package manager for Python.

pip install twilio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not format these like:
pip install twilio or

pip install twilio

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason. I just restored the old version of this file (and added a couple things that were in the rst variant): https://github.com/twilio/twilio-python/blob/320e3913cce3cc50694d28378d598b0444abe802/README.md

Copy link
Contributor

I would say to be consistent (e.g. PHP) we should use the pretty code formatting stuff.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but in the preview it still looks good. (shrug)

@childish-sambino
Copy link
Contributor Author

Don't merge yet. Some issue with sphinx doc generation referencing the rst README.

@childish-sambino childish-sambino merged commit 09a68ba into master Apr 22, 2019
@childish-sambino childish-sambino deleted the readme-md branch April 22, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0