Allow user to turn off nbf generation in jwts #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think the "security by default" ideology would ask that nbf is opt-out, not opt-in. |
jmctwilio
approved these changes
Aug 25, 2017
459135e to
b8b3be6
Compare
dougblack
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had reports that nbf causes problems because if they arent provided they would take the local system time, however since they are validated on twilio's servers that requires that the system that generated the jwt and the system that validates it have relatively synced clocks which cannot be guaranteed.
Nbf will continue to be set if the user passes it on construction.