Create dummy clients which will throw an exception when instantiated #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougblack
reviewed
Aug 18, 2017
twilio/rest/__init__.py
Outdated
| @@ -496,3 +497,75 @@ def __repr__(self): | |||
| :rtype: str | |||
| """ | |||
| 8000 | return '<Twilio {}>'.format(self.account_sid) | ||
|
|
|||
|
|
|||
| @deprecated_client | |||
There was a problem hiding this comment.
What if we just made one DeprecatedClient and then did
TwilioClient = DeprecatedClient
TwilioRestClient = DeprecatedClient
TwilioIpMessageClient = DeprecatedClient
dougblack
approved these changes
Aug 18, 2017
dougblack
suggested changes
Aug 18, 2017
twilio/base/obsolete.py
Outdated
| raise ObsoleteException("{} has been removed from this version of the library. " | ||
| "Please refer to current documentation for guidance." | ||
| .format(func.__name__)) | ||
| return func(*args, **kwargs) |
There was a problem hiding this comment.
No need for return here.
tests/unit/rest/test_client.py
Outdated
|
|
||
| class TestDummyClients(unittest.TestCase): | ||
| def test_deprecation_error_twilioclient(self): | ||
| self.assertRaises(DeprecationWarning, TwilioClient, |
dougblack
reviewed
Aug 18, 2017
twilio/rest/__init__.py
Outdated
| @obsolete_client | ||
| class TwilioClient(object): | ||
| """ Dummy client which provides no functionality. Please use | ||
| Twilio.Rest.Client instead. """ |
There was a problem hiding this comment.
Should be lowercase twilio.rest.Client.
dougblack
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.