8000 Fix broken Python 3.3, 3.4, and 3.5 by ilanbiala · Pull Request #360 · twilio/twilio-python · GitHub
[go: up one dir, main page]
Skip to content

Fix broken Python 3.3, 3.4, and 3.5 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2017
Merged

Fix broken Python 3.3, 3.4, and 3.5 #360

merged 1 commit into from
Jun 27, 2017

Conversation

ilanbiala
Copy link
Contributor
@ilanbiala ilanbiala commented Jun 19, 2017 •
edited
Loading

json.loads only accepts str types in Python >3 and <3.6, so this PR converts all returned response.content objects to str from bytes.

Fixes #358
Fixes #359

@ilanbiala ilanbiala requested a review from codejudas June 19, 2017 19:59
@ilanbiala ilanbiala force-pushed the fix-358 branch 6 times, most recently from ce52d44 to ac9ff13 Compare June 19, 2017 21:21
@kandhan-kuhan-t kandhan-kuhan-t mentioned this pull request Jun 20, 2017
Closed
@ilanbiala ilanbiala force-pushed the fix-358 branch 3 times, most recently from 44dc322 to 857565d Compare June 21, 2017 03:34
@ilanbiala ilanbiala requested review from dougblack, jingming, a user and jmctwilio June 21, 2017 03:35
dougblack
dougblack approved these changes Jun 21, 2017
View reviewed changes
twilio/http/validation_client.py Outdated
@@ -2,7 +2,7 @@

from requests import Request, Session

from twilio.compat import urlparse
from twilio.compat import urlparse, string_compat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove if we don't use this anywhere.

@ilanbiala
Use requests library response.text (Unicode) instead of response.cont…
e4c4154 
…ent (bytes), and add tests with Unicode strings
@ilanbiala ilanbiala mentioned this pull request Jun 21, 2017
Closed
@ilanbiala ilanbiala merged commit 039a843 into master Jun 27, 2017
@ilanbiala ilanbiala deleted the fix-358 branch June 27, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougblack dougblack dougblack approved these changes

@codejudas codejudas Awaiting requested review from codejudas

@jingming jingming Awaiting requested review from jingming

@jmctwilio jmctwilio Awaiting requested review from jmctwilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilanbiala @dougblack
0