8000 [DEVX-4966] Remove max page size coercion from library. by jmctwilio · Pull Request #350 · twilio/twilio-python · GitHub
[go: up one dir, main page]
Skip to content

[DEVX-4966] Remove max page size coercion from library. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2017
Merged

[DEVX-4966] Remove max page size coercion from library. #350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2c9b92
[DEVX-4966] Remove max page size coercion from library.
jmctwilio Jun 9, 2017
43409be
Remove 'count' from expected metadata.
jmctwilio Jun 12, 2017
4f56940
Removing files with generated counts.
jmctwilio Jun 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions twilio/base/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ class Version(object):
"""
Represents an API version.
"""
MAX_PAGE_SIZE = 1000

def __init__(self, domain):
"""
Expand Down Expand Up @@ -140,9 +139,7 @@ def read_limits(self, limit=None, page_size=None):
if limit is not None:

if page_size is None:
# If there is no user-specified page_size, pick the most
# network efficient size
page_size = min(limit, self.MAX_PAGE_SIZE)
page_size = limit

page_limit = int(ceil(limit / float(page_size)))

Expand Down
0