Voice response devx5021 and Python testing, compatibility #346
Conversation
|
|
||
| venv: | ||
| virtualenv venv | ||
| virtualenv --python=python venv |
There was a problem hiding this comment.
whats the benefit of doing --python=python? Isnt that the default?
There was a problem hiding this comment.
Adding --python=python uses the standard alias Travis-CI sets up in each environment, which seemed to be the simplest way to use the intended test version. I can look around for another way if you think there is one.
twilio/http/validation_client.py
Outdated
| try: | ||
| from urllib.parse import urlparse | ||
| except ImportError: | ||
| from urlparse import urlparse |
There was a problem hiding this comment.
We might want to do this in the compat.py file and then import urlparse from that so this file doesnt have to care which version of python its being run under.
twilio/http/validation_client.py
Outdated
| ) | ||
|
|
||
| return Response(int(response.status_code), response.content.decode('utf-8')) | ||
| # return Response(int(response.status_code), response.content.decode('utf-8')) |
| lineno=func.func_code.co_firstlineno + 1 | ||
| ) | ||
| warnings.simplefilter('always', DeprecationWarning) | ||
| warnings.warn("Call to deprecated function {}.".format(func.__name__), category=DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
why did this need to change?
There was a problem hiding this comment.
func.func_code is no longer an attribute in Python 3, and the decorator is only used on grants.py:108.
…sing correct Python version in each test environment) Install appropriate version of virtualenv for python, fixes Python 3.6 build because Travis-CI comes with virtualenv 12.0.1 by default
|
Pushing fixes and ammending commits. |
d922f61 to
af88416
Compare
twilio/compat.py
Outdated
| @@ -1,3 +1,5 @@ | |||
| import six | |||
… http_client was converted as well and now has tests.
af88416 to
3519817
Compare
mutedparameter