Next gen twiml #316
Merged
Next gen twiml #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougblack
reviewed
Mar 6, 2017
twilio/twiml/__init__.py
Outdated
|
|
||
| def append(self, verb): | ||
| self.verbs.append(verb) | ||
| return verb |
There was a problem hiding this comment.
Might be nicer to return self here.
response.append(Dial()).append(Sms())
codejudas
suggested changes
Mar 6, 2017
twilio/twiml/__init__.py
Outdated
| else: | ||
| return xml | ||
|
|
||
| def xml(self): |
There was a problem hiding this comment.
or prefix with _ if not public
| method=None, | ||
| action=None, | ||
| status_callback=None, | ||
| **kwargs): |
There was a problem hiding this comment.
...ew one line per param?
There was a problem hiding this comment.
I like the other style where you keep them inline until the length limit then wrap to the next line. but not a big deal.
twilio/twiml/__init__.py
Outdated
|
|
||
| return el | ||
|
|
||
| def append(self, verb): |
There was a problem hiding this comment.
Check if its an instance of TwiML?
There was a problem hiding this comment.
I like this, it would help prevent mistakes.
codejudas
approved these changes
Mar 6, 2017
dougblack
reviewed
Mar 7, 2017
twilio/twiml/__init__.py
Outdated
| :return: | ||
| """ | ||
| if not isinstance(verb, TwiML): | ||
| raise TwiMLException() |
There was a problem hiding this comment.
Let's add a message like "can't nest responses".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.