Fixed issues with ipmessaging #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update calls
- Tests are also updated
- update calls - Tests are also updated
| """ | ||
| kwargs = { | ||
| "friendly_name": friendly_name, | ||
| "type": type, |
There was a problem hiding this comment.
does this override the type method?
There was a problem hiding this comment.
I dont think so, but is not the right parameter name. I will change it.
| @@ -1,5 +1,7 @@ | |||
| from .base import set_twilio_proxy | |||
| from .client import TwilioRestClient | |||
| from .conversations import TwilioConversationsClient | |||
There was a problem hiding this comment.
this required? or should it be included below as well?
There was a problem hiding this comment.
yes this makes importing TwilioConversationsClient, TwilioIpMessagingClient.. simpler.
I will add these two to pyflakes list.
to _hush_pyflakes variable.
|
+1 |
eq19
pushed a commit
to VirtualNetworks/parser
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.