8000 Ensure the `Calls.iter` method filters like the `Calls.list` method. by goodtune · Pull Request #193 · twilio/twilio-python · GitHub
[go: up one dir, main page]
Skip to content

Ensure the Calls.iter method filters like the Calls.list method. #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2014
Merged

Ensure the Calls.iter method filters like the Calls.list method. #193

merged 3 commits into from
Nov 20, 2014

Conversation

goodtune
Copy link
Contributor

It might be better to refactor the conversion of method arguments to REST API querystring parameters, but this gets the job done with no risk of regression on Calls.list method.

@skimbrel
Copy link
Contributor

+1, thanks for the catch

skimbrel added a commit that referenced this pull request Nov 20, 2014
@skimbrel
Merge pull request #193 from goodtune/rest-calls-iterator-filters
22ef5cd 
Ensure the `Calls.iter` method filters like the `Calls.list` method.
@skimbrel skimbrel merged commit 22ef5cd into twilio:master Nov 20, 2014
@goodtune goodtune deleted the rest-calls-iterator-filters branch November 20, 2014 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodtune @skimbrel
0