Set the name of the logger to twilio #178
Jump to bottom
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,5 @@ | |||
| import logging | |||
| logger = logging.getLogger('twilio') | |||
There was a problem hiding this comment.
Proper python logging for a module.
Twilio is currently logging to the root log handler. If I set my application to debug mode, I might not want to see your logs. So therefore with this change you can do:
logging.getLogger("twilio").setLevel(logging.ERROR)
in your main application so that you can suppress twilio to only error messages.
There was a problem hiding this comment.
This seems fine to me, but please move the logger initialization down below the rest of the imports.
|
Good to go or should I rebase to one commit? |
|
Works for me. Merging. |
skimbrel
added a commit
that referenced
this pull request
Aug 14, 2014
Set the name of the logger to twilio
eq19
pushed a commit
to VirtualNetworks/parser
that referenced
this pull request
May 1, 2025
…n without adding any value. Fix twilio#178.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.