8000 Add automatic PEP8 compliance via Flake8 by kyleconroy · Pull Request #112 · twilio/twilio-python · GitHub
[go: up one dir, main page]

Skip to content

Add automatic PEP8 compliance via Flake8 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2013
Merged

Add automatic PEP8 compliance via Flake8 #112

merged 3 commits into from
Mar 11, 2013

Conversation

kyleconroy
Copy link
Contributor

We've had some problems with using the same test name multiple times. With Flake8, we'll be notified any time this happens, as the build will fail.

@kyleconroy
Copy link
Contributor Author

Fixes #81

return dict(p)
transformed_parameters = {}

for key, value in iteritems(parameters):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you unpythonize ? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-->

It was an ugly list comprehension 👍

@gbin
Copy link
Contributor
gbin commented Mar 11, 2013

👍

kyleconroy added a commit that referenced this pull request Mar 11, 2013
Add automatic PEP8 compliance via Flake8
@kyleconroy kyleconroy merged commit bb9f4a3 into master Mar 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0