Make PhoneNumbers.update_instance consistent with PhoneNumber.update #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to PhoneNumber.update allowed passing "status_callback" as "status_callback_url" for convenience. This change adds this conveniece for PhoneNumbers.update_instance for consistency. Also, kwargs is now copied to avoid side effects and status_callback_url is now removed from kwargs as it is only relevant to update and update_instance.
gbin
added a commit
that referenced
this pull request
Jan 7, 2013
Make PhoneNumbers.update_instance consistent with PhoneNumber.update
eq19
pushed a commit
to VirtualNetworks/parser
that referenced
this pull request
May 1, 2025
Make withIEStorage strict compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to PhoneNumber.update allowed passing "status_callback"
as "status_callback_url" for convenience. This change adds this
conveniece for PhoneNumbers.update_instance for consistency. Also,
kwargs is now copied to avoid side effects and status_callback_url is now
removed from kwargs as it is only relevant to update and
update_instance.