8000 fix: Fixing Flaky Tests by priyanka-28 · Pull Request #725 · twilio/twilio-java · GitHub
[go: up one dir, main page]
Skip to content

fix: Fixing Flaky Tests #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2022
Merged

fix: Fixing Flaky Tests #725

merged 3 commits into from
Dec 13, 2022

Conversation

priyanka-28
Copy link
Contributor

Fixes

The test in com.twilio.jwt.taskrouter.PolicyTest#testToJsonexpress non-deterministic behaviour and thus fail with nondex. The fix is adding the annotation JSONPropertyOrder and changing the order of the json attributes to ensure determinism.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Priyanka Awatramani added 2 commits December 11, 2022 04:11
Issue-724 Fixed Flaky Tests
< 8000 input type="hidden" name="dropdown_direction" value="s" autocomplete="off" data-targets="batch-deferred-content.inputs" />
4986510
Issue-724 Fixed Flaky Tests
a437410
kridai
kridai reviewed Dec 12, 2022
View reviewed changes
src/main/java/com/twilio/jwt/taskrouter/Policy.java Outdated
@@ -17,6 +18,7 @@
@JsonAutoDetect(fieldVisibility = JsonAutoDetect.Visibility.ANY)
@JsonInclude(JsonInclude.Include.NON_NULL)
@JsonIgnoreProperties(ignoreUnknown = true)
@JsonPropertyOrder({"allowed","method","postFilter","queryFilter","url"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this to @JsonPropertyOrder(alphabetic = true) . This way we don't need to keep track of new properties being added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated the PR!

< 8000 /div>
@rakatyal
Copy link
Contributor

Fixes #724

kridai
kridai approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor
@kridai kridai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kridai kridai merged commit facab19 into twilio:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
< 6446 div id="partial-discussion-sidebar" class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjExNTg4OTcyNjYiLCJ0IjoxNzUwOTU3OTg1fQ==--23d53ad457120594f6a330335b356c0c83aca5b23ddcf9c534aaa8dd76552a0f" data-gid="PR_kwDOAASxFM5FE15y" data-channel-event-name="sidebar_updated" data-url="/twilio/twilio-java/issues/725/show_partial?partial=issues%2Fsidebar" data-project-hovercards-enabled>
Reviewers

@kridai kridai kridai approved these changes

@xieyt2000 xieyt2000 xieyt2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priyanka-28 @rakatyal @kridai @xieyt2000
0