8000 feat: Use `XmlWriter` to serialize TwiML instead of using `XDocument` by Swimburger · Pull Request #669 · twilio/twilio-csharp · GitHub
[go: up one dir, main page]
Skip to content

feat: Use XmlWriter to serialize TwiML instead of using XDocument #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Use XmlWriter to serialize TwiML instead of using XDocument #669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c601216
Use XmlWriter instead of XDocument to reduce memory and increase perf…
Swimburger Feb 2, 2023
8816ba1
Document methods
Swimburger Feb 2, 2023
e14d0eb
Merge branch 'main' into use-xml-writer
Swimburger May 22, 2023
4a05866
add xml:lang attr to tests
Swimburger Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add xml:lang attr to tests
  • Loading branch information
@Swimburger
Swimburger committed Jun 6, 2023
commit 4a05866ba7131605fe55b47899bbed6b1d56c01c
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/ApplicationSidTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ public void TestElementWithExtraAttributes()
var elem = new ApplicationSid();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<ApplicationSid newParam1=\"value\" newParam2=\"1\" />",
"<ApplicationSid newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/ApplicationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,11 @@ public void TestElementWithExtraAttributes()
var elem = new Application();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Application newParam1=\"value\" newParam2=\"1\" />",
"<Application newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/AutopilotTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ public void TestElementWithExtraAttributes()
var elem = new Autopilot();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Autopilot newParam1=\"value\" newParam2=\"1\" />",
"<Autopilot newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
1 change: 1 addition & 0 deletions test/Twilio.Test/TwiML/BodyTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,5 @@ public void TestMixedContent()
);
}
}

}
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/ClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,11 @@ public void TestElementWithExtraAttributes()
var elem = new Client();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Client newParam1=\"value\" newParam2=\"1\" />",
"<Client newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
F438 elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/ConferenceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ public void TestElementWithExtraAttributes()
var elem = new Conference();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Conference newParam1=\"value\" newParam2=\"1\" />",
"<Conference newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/ConfigTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ public void TestElementWithExtraAttributes()
var elem = new Config();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Config newParam1=\"value\" newParam2=\"1\" />",
"<Config newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/ConnectTest.cs
View file Edit file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ public void TestElementWithExtraAttributes()
var elem = new Connect();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Connect newParam1=\"value\" newParam2=\"1\" />",
"<Connect newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/ConversationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ public void TestElementWithExtraAttributes()
var elem = new Conversation();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Conversation newParam1=\"value\" newParam2=\"1\" />",
"<Conversation newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/DialTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,11 @@ public void TestElementWithExtraAttributes()
var elem = new Dial();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Dial newParam1=\"value\" newParam2=\"1\" />",
"<Dial newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/EchoTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@ public void TestElementWithExtraAttributes()
var elem = new Echo();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Echo newParam1=\"value\" newParam2=\"1\" />",
"<Echo newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/EnqueueTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,11 @@ public void TestElementWithExtraAttributes()
var elem = new Enqueue();
elem.SetOption("newParam1", "value");
elem.SetOption("newParam2", 1);
elem.SetOption("xml:lang", "en");

Assert.AreEqual(
"<?xml version=\"1.0\" encoding=\"utf-8\"?>" + Environment.NewLine +
"<Enqueue newParam1=\"value\" newParam2=\"1\" />",
"<Enqueue newParam1=\"value\" newParam2=\"1\" xml:lang=\"en\" />",
elem.ToString()
);
}
Expand Down
3 changes: 2 additions & 1 deletion test/Twilio.Test/TwiML/FaxResponseTest.cs
View file
Open in desktop