Fix path when possible when an exception occurs #4643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
May 28, 2025
| @@ -122,8 +122,12 @@ private function updateRepr(): void | |||
| if ($punctuation = '.' === $last || '?' === $last ? $last : '') { | |||
| $this->message = substr($this->message, 0, -1); | |||
| } | |||
| if ($this->source && $this->source->getName()) { | |||
| $this->message .= \sprintf(' in "%s"', $this->source->getName()); | |||
| if ($this->source) { | |||
There was a problem hiding this comment.
This change looks wrong to me. Here, we want to use the name of the template, not the path. The path/line information is part of the regular Exception properties.
There was a problem hiding this comment.
But we need to do that to make Symfony works. I don't know how we can do better.
|
As discussed in the Symfony Slack channel, the HtmlErrorRenderer of Symfony must be fixed to stop assuming that anything looking like
We actually don't put a path at all (even relative). We put a Twig template name. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 29, 2025
…t exist (lyrixx) This PR was merged into the 6.4 branch. Discussion ---------- [ErrorHandler] Do not transform file to link if it does not exist | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT see twigphp/Twig#4643 Commits ------- 2dfac6b [ErrorHandler] Do not transform file to link if it does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an error in the integration between Twig and Symfony
If a template throw an error, Symfony will enhance the message.
If a path is found in the message, it'll turn it to a link
https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php#L304-L307
https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/ErrorHandler/Resources/views/exception.html.php#L18
However, in twig, we don't put an absolute path, but a relative one.
So it does not work. This PR puts an absolute link if possible
Caution
I did not updated the test yet, I'm waiting for feedback