add machine-readable version constants #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
SpacePossum
reviewed
Nov 7, 2016
| const MAJOR_VERSION = 1; | ||
| const MINOR_VERSION = 27; | ||
| const RELEASE_VERSION = 1; | ||
| const EXTRA_VERSION = 'DEV'; |
There was a problem hiding this comment.
what would value will this have in releases?
There was a problem hiding this comment.
In stable releases, this will be the empty string (see https://github.com/symfony/symfony/blob/v2.7.20/src/Symfony/Component/HttpKernel/Kernel.php#L66).
|
@fabpot Should work too. But checking for integer values is faster and allows for greater flexibility. |
|
I know and anyway, I like that, same as we have in Symfony. @SpacePossum For releases, EXTRA would be empty (exact same thing as for Symfony). |
|
nice, 👍 🚢 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 7, 2016
This PR was merged into the 1.x branch. Discussion ---------- add machine-readable version constants This will make it easier to implement version depending features (see symfony/symfony#20440 (comment) for an example). Commits ------- bf07db4 add machine-readable version constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to implement version depending features (see symfony/symfony#20440 (comment) for an example).