raw filter on the empty string #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the content if the content is an empty string or undefined. The resulting output is [Object] instead of the (expected) empty string.
7658a92 to
ae6c641
Compare
maxhelias
approved these changes
Dec 23, 2019
|
Thanks for taking care of this issue! I just noticed the regression too. @RobLoach Do you have an estimated date for the next release? |
|
Hello @RobLoach! do you have an update yet? |
|
Thanks for the ping! Hope to get a release out today. |
|
Great! Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raw filter return a new Markup(content) which may itself return content
if content is the empty string. The resulting output was
[Object]instead of the expected empty string.