Support Windows and AmigaOS style paths #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aren't there OS specific flags that can be used to determine the OS platforms? If we wrap the implementation under compiler flags, it might be beneficial? |
|
This pull request has been implemented manually in the May 2024 Update. As @SimantoR suggested, the distinction has been made using _WIN32 and amigaos compiler defines that are set in those environments (yes, _WIN32 is also defined on 64 bit windows systems). |
|
closing with above explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File part extraction won't work correctly when using backslashes instead of slashes, as it is the default on Windows. Also, filename extraction won't work on AmigaOS in case the filename comes directly after the drive letter, e.g.
T:tempfile. This PR fixes both issues.