[MLIR][mlir-link] Linkage tests #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple in this context are those that have a constant initializer and not an initializer region.
hbrodin
approved these changes
Feb 5, 2025
xlauko
pushed a commit
that referenced
this pull request
Mar 28, 2025
This PR introduces bitfelds support. This now works:
```
typedef struct {
int a1 : 4;
int a2 : 28;
int a3 : 16;
int a4 : 3;
int a5 : 17;
int a6 : 25;
} A;
void init(A* a) {
a->a1 = 1;
a->a2 = 321;
a->a3 = 15;
a->a4 = -2;
a->a5 = -123;
a->a6 = 1234;
}
void print(A* a) {
printf("%d %d %d %d %d %d\n",
a->a1,
a->a2,
a->a3,
a->a4,
a->a5,
a->a6
);
}
int main() {
A a;
init(&a);
print(&a);
return 0;
}
```
the output is:
`1 321 15 -2 -123 1234`
xlauko
pushed a commit
that referenced
this pull request
Mar 28, 2025
xlauko
pushed a commit
that referenced
this pull request
Mar 28, 2025
…m#268) This is an updated PR for [PR explained in [PR llvm#261](llvm/clangir#261) which now can be safely closed. First of all, let me introduce how do the bitfields looks like in CIR. For the struct `S` defined as following: ``` typedef struct { int a : 4; int b : 27; int c : 17; int d : 2; int e : 15; unsigned f; } S; ``` the CIR type is `!ty_22S22 = !cir.struct<struct "S" {!u32i, !u32i, !u16i, !u32i} #cir.record.decl.ast>` where all the bitfields are packed in the first three storages. Also, the next bugs was fixed: - type mismatch - index out of bounds - single bitfield of size < 8 The cases covered with tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.