Manage observability at entrypoint and router level #11308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
requested changes
Nov 28, 2024
There was a problem hiding this comment.
IMHO, the general Observability section of the documentation should be updated explaining the configuration procedure (global in static conf + default value + granular).
Otherwise, I love it ❤️
sdelicata
approved these changes
Dec 6, 2024
| } | ||
|
|
||
| // ShouldAddMetrics returns whether the metrics should be enabled for the given resource. | ||
| func (o *ObservabilityMgr) ShouldAddMetrics(resourceName string) bool { | ||
| // ShouldAddMetrics returns whether the metrics should be enabled for the given resource and the observability config. |
There was a problem hiding this comment.
Suggested change
| // ShouldAddMetrics returns whether the metrics should be enabled for the given resource and the observability config. | |
| // ShouldAddMetrics returns whether the metrics should be enabled for the given serviceName and the observability config. |
4101917 to
be4f43e
Compare
1 task
sheddy-traefik
suggested changes
Dec 11, 2024
4cdbecf to
9c0b3d1
Compare
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
2D4D
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces options to control observability (access-logs, metrics and tracing) at entrypoint and router level.
Motivation
Fixes #6059
Fixes #10646
More
Additional Notes
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com